Skip to content

chore(clerk-js,types,localizations): Clean up empty subscription list #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025

Conversation

aeliox
Copy link
Contributor

@aeliox aeliox commented May 12, 2025

Description

Cleans up the display of the empty subscription list / button when the default free plan is hidden.

Before:
Screenshot 2025-05-12 at 3 38 28 PM

After:
Screenshot 2025-05-12 at 3 38 06 PM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 1318255

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/clerk-react Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 6:15pm

@panteliselef
Copy link
Member

How does someone end up with the empty list ? I see that we are displaying the free plan instead.

@alexcarpenter
Copy link
Member

How does someone end up with the empty list ? I see that we are displaying the free plan instead.

When the free plan is set to not publicly visible.

@aeliox aeliox merged commit fbf3cf4 into main May 13, 2025
32 checks passed
@aeliox aeliox deleted the keiran/com-779-empty-subscriptions-free-plan branch May 13, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants