Properly marked many functions as private

clientIO · Sep 23, 2015 · 1df4ec6 · 1df4ec6
1 parent 9e76097
commit 1df4ec6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/lib/client/client.js b/lib/client/client.js
@@ -65,7 +65,7 @@ Client.prototype._findServerForManager = function (manager, refreshCache) {
 
         var tasks = [];
         for ( var i = 0; i < self.servers.length; i+=1 ) {
-            tasks.push(self.servers[i].api.getManagers());
+            tasks.push(self.servers[i].api._getManagers());
         }
 
         promise = BPromise.all(tasks)

diff --git a/lib/server/core/manager.js b/lib/server/core/manager.js
@@ -74,7 +74,7 @@ Manager.prototype._requestQuota = function (managerName, scope, resources, optio
 
             for ( var r = 0; r < self.rules.length; r+=1 ) {
                 for ( var s = 0; s < filterForResources.length; s+=1 ) {
-                    if (self.rules[r].limitsResource(filterForResources[s])) {
+                    if (self.rules[r]._limitsResource(filterForResources[s])) {
                         relevantRules.push(self.rules[r]);
                         break;
                     }
@@ -92,7 +92,7 @@ Manager.prototype._requestQuota = function (managerName, scope, resources, optio
 
         function enqueue(rule, queuedRequest) {
 
-            var p = rule.enqueue(managerName, scope, resources, options, queuedRequest);
+            var p = rule._enqueue(managerName, scope, resources, options, queuedRequest);
             if (p === null) {
                 reject(new errors.OutOfQuotaError(managerName));
             } else if (queuedRequest && queuedRequest.valid === false) {
@@ -108,7 +108,7 @@ Manager.prototype._requestQuota = function (managerName, scope, resources, optio
         }
 
         for ( var i = 0; i < relevantRules.length; i += 1 ) {
-            if (!relevantRules[i].isAvailable(managerName, scope, resources, options, queuedRequest)) {
+            if (!relevantRules[i]._isAvailable(managerName, scope, resources, options, queuedRequest)) {
 
                 enqueue(relevantRules[i], queuedRequest);
 
@@ -127,7 +127,7 @@ Manager.prototype._requestQuota = function (managerName, scope, resources, optio
 
         var dismissCallbacks = [];
         for ( var k = 0; k < relevantRules.length; k+=1 ) {
-            var cb = relevantRules[k].reserve(managerName, scope, resources, options);
+            var cb = relevantRules[k]._reserve(managerName, scope, resources, options);
             if (cb) {
                 dismissCallbacks.push({
                     rule: relevantRules[k],

diff --git a/lib/server/core/rule.js b/lib/server/core/rule.js
@@ -90,7 +90,7 @@ Rule.prototype._getResource = function () {
     return this.options.resource;
 };
 
-Rule.prototype.limitsResource = function (resource) {
+Rule.prototype._limitsResource = function (resource) {
 
     if (!this.options.resource) {
         return true;
@@ -100,7 +100,7 @@ Rule.prototype.limitsResource = function (resource) {
 
 };
 
-Rule.prototype.isAvailable = function (managerName, scope, resources, options, queuedRequest) {
+Rule.prototype._isAvailable = function (managerName, scope, resources, options, queuedRequest) {
 
     var scopeBundle = this._getBundleForScope(managerName, scope);
 
@@ -115,7 +115,7 @@ Rule.prototype.isAvailable = function (managerName, scope, resources, options, q
 
 };
 
-Rule.prototype.enqueue = function (managerName, scope, resources, options, queuedRequest) {
+Rule.prototype._enqueue = function (managerName, scope, resources, options, queuedRequest) {
 
     if (_.isUndefined(this._Queueing)) {
         return null;
@@ -165,7 +165,7 @@ Rule.prototype.enqueue = function (managerName, scope, resources, options, queue
 
 };
 
-Rule.prototype.reserve = function (managerName, scope, resources, options) {
+Rule.prototype._reserve = function (managerName, scope, resources, options) {
     var resourceAmount = this._getResourceAmount(resources);
     return this._getBundleForScope(managerName, scope).throttling.reserve(resourceAmount, options);
 };

diff --git a/lib/server/server.js b/lib/server/server.js
@@ -38,7 +38,7 @@ Server.prototype.addManager = function (managerName, managerOrOptions) {
 
 };
 
-Server.prototype.getManagers = function () {
+Server.prototype._getManagers = function () {
     return BPromise.resolve(_.keys(this._managers));
 };
-Original file line number
+Diff line change
@@ Expand Up @@
     };
-    Server.prototype.getManagers = function () {
+    Server.prototype._getManagers = function () {
         return BPromise.resolve(_.keys(this._managers));
     };
@@ Expand Down @@