Autocasting args of py{*} family of macros to python via py/->python
#225
Conversation
jjtolton
changed the title
py{*} family of macros to python via py/->pythonpy{*} family of macros to python via py/->python
jjtolton
changed the title
py{*} family of macros to python via py/->python
|
Maybe this fixes one case, but this line is still wrong: (and I had the NPE on this line) Whenever this line is used with an empty map, there will be an NPE. |
|
It is easily fixed, by doing: |
1 similar comment
|
It is easily fixed, by doing: |
|
Well it doesn't crash any tests so I don't see why not. I'll move the autocasting to a different issue. |
jjtolton
changed the title
py{*} family of macros to python via py/->python
|
The question here is do you always want to completely copy all data into the python and is that even possible. The system is setup to allow large objects that may not have a full python representation to be bridged. @behrica's fix still allows this while this fix will cause at least some things that did work before to fail as the entire JVM object may not be copyable to python. The tradeoff is that copying may be both more robust and faster in a lot of cases as then Python functions down the line deal with native Python objects and not bridged objects. As it is users can manually call as-python or ->python to choose which they want but I think this |
|
@cnuernber makes good points, closing |
Autocasting args of
py{*}family of macros to python viapy/->python