[completion] Fix cider-enable-cider-completion-style #3800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
enable-completion-style-non-interactive
branch
from
725dff7 to
b97f179
Compare
alexander-yakushev
changed the title
bbatsov
reviewed
Mar 31, 2025
| @@ -290,7 +290,7 @@ This style supports non-prefix completion candidates returned by the | |||
| completion backend. Only affects the `cider' completion category. If ARG | |||
| is `1' or nil, enables the custom completion style; if `-1', disables it." | |||
| (interactive) | |||
| (if (= arg -1) | |||
| (if (eq arg -1) | |||
There was a problem hiding this comment.
Seem weird a bit, as eq is supposed to check if you're comparing something with itself (mostly for symbols).
There was a problem hiding this comment.
There's #3798, so it might be good to make some explicit nil check for the case with no argument passed.
There was a problem hiding this comment.
= was failing when arg is nil, so I switched to eq. Should I have used equal?
There was a problem hiding this comment.
I think it's much better to just wrap everything in some let that sets arg explicitly if nil. I usually do this to make sure I don't have deal with nil anywhere in a special way.
There was a problem hiding this comment.
No problem, I'll fix it on the next iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It being interactive works strangely with the newly added optional argument I've added.