chore(deps): update dependencies #166
Merged
+212
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for new releases of cert-manager, controller-runtime, and Go.
This changeset updates to using Go 1.24 features. The VCS tag and commit information is now embedded into the controller binary by the go tool, replacing the previous method of embedding via `-ldflags`. This version is now used if the version is not explicitly set at build time. The controller-gen tool is now set via the tools directive in go.mod, replacing the previous "package tools". The CRDs and RBAC files are now generated using the `go tool` command. The test files have been updated to use `t.Context()` instead of manually setting up a cancellable context (or worse, using `context.Background()` or `context.TODO()`). This context is cancelled by Go before calling the Cleanup functions. The remaining vestiges of loop variable scoping have also been removed, along with a lite tidying of some older test files.
jrcichra
approved these changes
Feb 18, 2025
muff1nman
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates to using Go 1.24 features.
The VCS tag and commit information is now embedded into the controller
binary by the go tool, replacing the previous method of embedding via
-ldflags. This version is now used if the version is not explicitlyset at build time.
The controller-gen tool is now set via the tools directive in go.mod,
replacing the previous "package tools". The CRDs and RBAC files are now
generated using the
go toolcommand.The test files have been updated to use
t.Context()instead ofmanually setting up a cancellable context (or worse, using
context.Background()orcontext.TODO()). This context is cancelledby Go before calling the Cleanup functions.
The remaining vestiges of loop variable scoping have also been removed,
along with a lite tidying of some older test files.