Skip to content

Commit

Permalink
move GODEBUG from code to readme
Browse files Browse the repository at this point in the history
  • Loading branch information
nickysemenza committed Oct 13, 2021
1 parent dcb780a commit dae41a4
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 17 deletions.
1 change: 0 additions & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ jobs:
test:
runs-on: ubuntu-latest
env:
GOFLAGS: "-mod=vendor"
GODEBUG: x509ignoreCN=0
steps:
- uses: actions/checkout@v2
Expand Down
16 changes: 2 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,9 @@ encryption and decryption server.
[![Go Test](https://github.com/cloudflare/redoctober/actions/workflows/go.yml/badge.svg)](https://github.com/cloudflare/redoctober/actions/workflows/go.yml)
[![Coverage Status](http://codecov.io/github/cloudflare/redoctober/coverage.svg?branch=master)](http://codecov.io/github/cloudflare/redoctober?branch=master)

This project requires [Go 1.16](http://golang.org/doc/install#download)
or later to compile. Verify your go version by running `go version`:
Note: `GODEBUG=x509ignoreCN=0` must be set during runtime (#204)

$ go version
go version go1.4

As with any Go program you do need to set the
[GOPATH environment variable](http://golang.org/doc/code.html#GOPATH)
accordingly. With Go set up you can download and compile sources:

$ go get github.com/cloudflare/redoctober

And run the tests:

$ go test github.com/cloudflare/redoctober...
This project requires [Go 1.16](http://golang.org/doc/install#download) or later to compile.

## Running

Expand Down
1 change: 0 additions & 1 deletion redoctober.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ func registerCli() {
//go:generate go run generate.go

func main() {
os.Setenv("GODEBUG", "x509ignoreCN=0") // need to keep using go1.16
registerCli()
var err error
if confFile != "" {
Expand Down
1 change: 0 additions & 1 deletion redoctober_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ func init() {
}

func setup(t *testing.T) (cmd *exec.Cmd) {
os.Setenv("GODEBUG", "x509ignoreCN=0")
const maxAttempts = 5

// Look for the redoctober binary in current directory and then in $GOPATH/bin
Expand Down

0 comments on commit dae41a4

Please sign in to comment.