Fix signature with escaping characters #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const-cloudinary
approved these changes
Jun 16, 2025
const-cloudinary
requested changes
Jun 17, 2025
| @@ -195,7 +195,7 @@ public boolean verifyNotificationSignature(String body, String timestamp, String | |||
| * @return whether response signature is valid or not | |||
| */ | |||
| public boolean verifyApiResponseSignature(String publicId, String version, String signature) { | |||
| return new ApiResponseSignatureVerifier(config.apiSecret, config.signatureAlgorithm).verifySignature(publicId, version, signature); | |||
| return new ApiResponseSignatureVerifier(config.apiSecret, config.signatureAlgorithm).verifySignature(publicId, version, signature, config.signatureVersion); | |||
There was a problem hiding this comment.
it should always use version 1, hardcoded.
| @@ -57,9 +57,9 @@ public ApiResponseSignatureVerifier(String secretKey, SignatureAlgorithm signatu | |||
| * | |||
| * @return true if response signature passed verification procedure | |||
| */ | |||
| public boolean verifySignature(String publicId, String version, String signature) { | |||
| public boolean verifySignature(String publicId, String version, String signature, int signatureVersion) { | |||
There was a problem hiding this comment.
and here too, version 1 hardcoded
const-cloudinary
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
Fix signature with escaping characters
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: