Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onProgress callback #4

Closed
wants to merge 4 commits into from
Closed

add onProgress callback #4

wants to merge 4 commits into from

Conversation

vincerubinetti
Copy link

@cmpolis Thank you for the library.

While using this library, I wanted to get a status update on the clustering, since it can often take a long time. I want to be able to give users feedback on how long the clustering will take, and I needed to expose that information.

That is what this PR has done. Please take a look.

@vincerubinetti
Copy link
Author

Closing this because it's actually not sufficient for my use case with web workers. I would've needed to include a postMessage call as well.

Instead I just made my own rewrite of this library entirely, which includes the functionality:
greenelab/hclust#1

@vincerubinetti vincerubinetti deleted the add-progress-callback branch March 5, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant