Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay Proto-X #32

Merged
merged 102 commits into from
May 30, 2024
Merged

Replay Proto-X #32

Changes from 1 commit
Commits
Show all changes
102 commits
Select commit Hold shift + click to select a range
5ea0984
copied replay_mythril.py over
wangpatrick57 Apr 15, 2024
1664890
added replay function
wangpatrick57 Apr 15, 2024
6dce17a
Baseilne -> Baseline
wangpatrick57 Apr 15, 2024
59c3d34
pqt -> query_timeout
wangpatrick57 Apr 15, 2024
ae99b21
repository -> tuning_steps
wangpatrick57 Apr 16, 2024
08829d8
removed logdir entirely
wangpatrick57 Apr 16, 2024
cd92d82
got rid of output_log_dir entirely
wangpatrick57 Apr 16, 2024
207097a
ray results now in dbgym workspace
wangpatrick57 Apr 16, 2024
93b0988
now linking hpo-ed params in symlinks
wangpatrick57 Apr 16, 2024
d2bb709
now linking tuning steps
wangpatrick57 Apr 16, 2024
7cd260f
replay main working
wangpatrick57 Apr 16, 2024
aa9b98f
wrote extract_from_task_run_fordpath
wangpatrick57 Apr 16, 2024
caf0d6c
now finding all replay dirs
wangpatrick57 Apr 17, 2024
64aaf15
added all configs to replay
wangpatrick57 Apr 17, 2024
6ece74d
added replayargs and deleted front of replay_step()
wangpatrick57 Apr 17, 2024
e341956
now copying params.json directly into data/
wangpatrick57 Apr 17, 2024
a531c2b
now copying params.json into tuning_steps
wangpatrick57 Apr 17, 2024
b5f1e8e
merged with integrate-boot
wangpatrick57 Apr 17, 2024
4471787
renamed boot_config_fpath to hpo_boot_config_fpath
wangpatrick57 Apr 17, 2024
315a69f
added hpo config fpath config to tune
wangpatrick57 Apr 17, 2024
4e9bde6
fixed bugs so that hpo runs
wangpatrick57 Apr 17, 2024
17dece3
fixed some comments
wangpatrick57 Apr 17, 2024
2f554e2
made it past first output.log loop
wangpatrick57 Apr 17, 2024
f035e01
now only reading folders in first loop
wangpatrick57 Apr 17, 2024
19310a3
fixed threshold limit
wangpatrick57 Apr 17, 2024
e084cc7
can now build PostgresEnv
wangpatrick57 Apr 17, 2024
0c3c146
now resetting and getting min reward
wangpatrick57 Apr 17, 2024
bac5238
single to double quotes
wangpatrick57 Apr 18, 2024
79cee72
maximal fixed
wangpatrick57 Apr 18, 2024
86acc80
num lines
wangpatrick57 Apr 18, 2024
a3038b5
initial fix to run_sample()
wangpatrick57 Apr 18, 2024
551fd67
fixed all parsing errors
wangpatrick57 Apr 18, 2024
0e2486b
run raw csv path fixed
wangpatrick57 Apr 18, 2024
55faf8e
maximal_only fixed
wangpatrick57 Apr 18, 2024
92020c3
now properly ignoring baseline
wangpatrick57 Apr 18, 2024
98d549b
now parsing action.json
wangpatrick57 Apr 18, 2024
41a4ac1
now reading prior_state.pkl correctly
wangpatrick57 Apr 18, 2024
132fb16
now outputting IndexAction instead of SQL string to action.txt
wangpatrick57 Apr 18, 2024
2646f73
done with combining index acts from action and previous
wangpatrick57 Apr 18, 2024
d49bdef
done with combining index acts from action and previous
wangpatrick57 Apr 18, 2024
0e3777f
done with creating index_modifaction_sqls
wangpatrick57 Apr 18, 2024
da8d078
done with shift_state
wangpatrick57 Apr 18, 2024
41a9059
run_sample running
wangpatrick57 Apr 18, 2024
1fcca5a
removed indexes from constraints
wangpatrick57 Apr 18, 2024
00b0c87
0.1 experiments
wangpatrick57 Apr 18, 2024
5cf5ef6
only stashing results for tune, and setting idx_name based on index c…
wangpatrick57 Apr 18, 2024
ca0bf85
added some comments about idx_name
wangpatrick57 Apr 18, 2024
d92707c
now always dumping page cache
wangpatrick57 Apr 18, 2024
82f9ea1
removed print statements
wangpatrick57 Apr 18, 2024
c2ad745
duration -> trial_duration
wangpatrick57 Apr 18, 2024
31f0521
added separate CLI arg for tune duration
wangpatrick57 Apr 18, 2024
9dcd36b
added print statements to investigate replay behavior
wangpatrick57 Apr 18, 2024
3175716
timeout -> workload_timeout
wangpatrick57 Apr 19, 2024
43ba9c3
got rid of modifying workload_timeout
wangpatrick57 Apr 19, 2024
019b4fc
added tuningmode enum
wangpatrick57 Apr 19, 2024
02049c4
is_hpo -> tuning_mode
wangpatrick57 Apr 19, 2024
e7012e1
replaced replay in pg_env with tuning_mode
wangpatrick57 Apr 19, 2024
243411c
changed HPO params to use enums instead of having different names
wangpatrick57 Apr 19, 2024
cbb87a7
hpo, tune, and replay all now not crashing
wangpatrick57 Apr 19, 2024
d88fd98
added workload timeout during replay param
wangpatrick57 Apr 19, 2024
bc66526
fixed race condition in multiple threads writing to pg.log
wangpatrick57 Apr 19, 2024
f09d38f
now linking to params.json for manual run_*/ traversal
wangpatrick57 Apr 19, 2024
867aa92
renamed reward in replay.py
wangpatrick57 Apr 19, 2024
74d70ff
more renaming
wangpatrick57 Apr 19, 2024
0e3aa51
comment changes
wangpatrick57 Apr 19, 2024
fbbee89
got rid of the 2 maximal params, 2 threshold params, and the 'samples…
wangpatrick57 Apr 19, 2024
106d4ea
got rid of extra row at bottom
wangpatrick57 Apr 19, 2024
7fc0bee
has_timeout -> did_any_query_timeout_in_original
wangpatrick57 Apr 19, 2024
b11d3f4
comment
wangpatrick57 Apr 19, 2024
84bcd79
refactored codebase so that all symlinks end with .link. full benchma…
wangpatrick57 Apr 19, 2024
8ee373d
now writing all holon action variations to action.pkl
wangpatrick57 Apr 22, 2024
d46c5a9
now checking equality with the index space
wangpatrick57 Apr 23, 2024
95be6fa
added comments describing why query timeout and workload timeout aren…
wangpatrick57 Apr 23, 2024
a909f1b
now reliably getting did_any_query_time_out_in_original
wangpatrick57 Apr 23, 2024
586b9a3
fixed did_workload_time_out_in_original and ignoring penalty in origi…
wangpatrick57 Apr 23, 2024
d91cc65
changes to scripts
wangpatrick57 Apr 23, 2024
aa1bca0
merge
wangpatrick57 Apr 23, 2024
cc11a8d
removing breaking after 10 iterations
wangpatrick57 Apr 23, 2024
c200e46
workload_time -> workload_runtime_accum
wangpatrick57 Apr 23, 2024
6beea71
workload_timeout -> this_execution_workload_timeout
wangpatrick57 Apr 23, 2024
006cc4a
removed time_left since it's redundant with workload_runtime_accum
wangpatrick57 Apr 23, 2024
a12348d
removed disable_pg_hint code
wangpatrick57 Apr 23, 2024
7320e06
removed noop index dead code
wangpatrick57 Apr 23, 2024
e1c3f07
removed dead var
wangpatrick57 Apr 23, 2024
9c45bf7
renamed BestQueryRun.timeout to timed_out
wangpatrick57 Apr 23, 2024
509f7dc
renamed stop_running to workload_timed_out
wangpatrick57 Apr 23, 2024
22617e0
refactored execute_workload() to separately return whether the worklo…
wangpatrick57 Apr 23, 2024
bf5fe73
replaced workload_runtime_accum with compute_total_workload_runtime()
wangpatrick57 Apr 23, 2024
6d237ec
now seeing whether workload or query timed out in replay
wangpatrick57 Apr 23, 2024
5bd43c6
now logging this_step_run_data before validity checks
wangpatrick57 Apr 23, 2024
c6b15dd
added replay_all_variations option
wangpatrick57 Apr 24, 2024
d0ed37f
added comments to _mutilate_action_with_metrics
wangpatrick57 Apr 24, 2024
b64fda2
added comment about best observed in replay.py
wangpatrick57 Apr 24, 2024
4fab4f2
changed bool of queries timed out to an actual num
wangpatrick57 Apr 24, 2024
a35a576
added info for num executed queries
wangpatrick57 Apr 25, 2024
6016334
reset now doesn't overwrite the results from step
wangpatrick57 Apr 25, 2024
4736315
wrote load_per_machine_envvars.sh
wangpatrick57 Apr 25, 2024
9849a99
added build_space_good_for_boot option
wangpatrick57 Apr 25, 2024
d2fb275
resolved some PR comments
wangpatrick57 Apr 28, 2024
af33bc7
added comment about tune
wangpatrick57 May 27, 2024
474d7ee
different tune trials during hpo now name their tuning_steps dir diff…
wangpatrick57 May 27, 2024
a6e00b9
now logging during HPO for both baseline and tuning steps
wangpatrick57 May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment
  • Loading branch information
@wangpatrick57
wangpatrick57 committed Apr 19, 2024
commit b11d3f4c4c21ee3dff0cb462a4bff70dc72fc827
2 changes: 1 addition & 1 deletion tune/protox/agent/off_policy_algorithm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def collect_rollouts(
new_obs, rewards, terms, truncs, infos = env.step(actions)
dones = terms or truncs
# We only stash the results if we're not doing HPO, or else the results from concurrent HPO would get
# stashed in the same directory and potentially crash the system.
# stashed in the same directory and potentially cause a race condition.
if self.logger and not tuning_mode == TuningMode.HPO:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also use the ray_trial_id to stash the results during HPO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

self.logger.stash_results(infos)

Expand Down