refactor: use Set for static list lookups

co3k · Jul 16, 2018 · 7e4e185 · 7e4e185
1 parent afe0ee1
commit 7e4e185
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/actions/introspection.js b/lib/actions/introspection.js
@@ -9,7 +9,7 @@ const bodyParser = require('../shared/selective_body');
 const rejectDupes = require('../shared/reject_dupes');
 const getParams = require('../shared/assemble_params');
 
-const introspectable = ['AccessToken', 'ClientCredentials', 'RefreshToken'];
+const introspectable = new Set(['AccessToken', 'ClientCredentials', 'RefreshToken']);
 const PARAM_LIST = new Set(['token', 'token_type_hint', ...tokenAuth.AUTH_PARAMS]);
 
 module.exports = function introspectionAction(provider) {
@@ -116,7 +116,7 @@ module.exports = function introspectionAction(provider) {
         }
       }
 
-      if (introspectable.includes(token.kind)) {
+      if (introspectable.has(token.kind)) {
         ctx.oidc.entity(token.kind, token);
       } else {
         return;

diff --git a/lib/actions/revocation.js b/lib/actions/revocation.js
@@ -8,7 +8,7 @@ const bodyParser = require('../shared/selective_body');
 const rejectDupes = require('../shared/reject_dupes');
 const getParams = require('../shared/assemble_params');
 
-const revokeable = ['AccessToken', 'ClientCredentials', 'RefreshToken'];
+const revokeable = new Set(['AccessToken', 'ClientCredentials', 'RefreshToken']);
 const PARAM_LIST = new Set(['token', 'token_type_hint', ...tokenAuth.AUTH_PARAMS]);
 
 module.exports = function revocationAction(provider) {
@@ -104,7 +104,7 @@ module.exports = function revocationAction(provider) {
 
       if (!token) return;
 
-      if (revokeable.includes(token.kind)) {
+      if (revokeable.has(token.kind)) {
         ctx.oidc.entity(token.kind, token);
       } else {
         return;