Skip to content

DOC-11497 Docs for obs: Enabling troubleshooting hot spots externally (e.g., logs or metrics) #19577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jun 26, 2025

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented May 1, 2025

Fixes DOC-11497

Added detect-hotspots.md and associated images.

Rendered previews:

Copy link

github-actions bot commented May 1, 2025

Files changed:

Copy link

netlify bot commented May 1, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit efad758
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/685db44dcdb5f400089d311f

Copy link

netlify bot commented May 1, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit efad758
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/685db44d3fa9b40008dde482

Copy link

netlify bot commented May 1, 2025

Deploy Preview for cockroachdb-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 0173eb8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6813b55b6c4a2d00084eadec

Copy link

netlify bot commented May 1, 2025

Netlify Preview

Name Link
🔨 Latest commit efad758
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/685db44d0f9c56000850018f
😎 Deploy Preview https://deploy-preview-19577--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@florence-crl florence-crl requested a review from kevin-v-ngo May 13, 2025 19:17
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the first look, @angles-n-daemons please review again.

Copy link

@angles-n-daemons angles-n-daemons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, couple more quick comments here.

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Doc! Few questions and suggestions.

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-v-ngo thanks for your first review, please take a second look.

@florence-crl florence-crl requested a review from kevin-v-ngo June 17, 2025 18:37
Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@florence-crl florence-crl requested a review from rmloveland June 23, 2025 19:34
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had some suggestions & questions which are non-blocking

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmloveland thanks for your thorough review. As always, thanks for pointing ways to link to other doc sections/pages.

@florence-crl florence-crl merged commit d6d00a9 into main Jun 26, 2025
6 checks passed
@florence-crl florence-crl deleted the DOC-11497 branch June 26, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants