Skip to content

Remove all mentions of foreign key dependencies from LDR sql docs #19783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

katmayb
Copy link
Contributor

@katmayb katmayb commented Jun 16, 2025

Fixes DOC-13999

Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit d022309
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/685576b422c8c50009dfc89c

Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit d022309
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/685576b4ce2d6a00080558d2

Copy link

netlify bot commented Jun 16, 2025

Netlify Preview

Name Link
🔨 Latest commit d022309
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/685576b429c4d7000896dec3
😎 Deploy Preview https://deploy-preview-19783--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@katmayb katmayb force-pushed the pcr-fk-dependencies branch from e375b5e to fe91584 Compare June 16, 2025 18:46
@katmayb katmayb marked this pull request as ready for review June 16, 2025 18:46
@katmayb katmayb requested a review from alicia-l2 June 16, 2025 19:06
Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i didn't see the 24.3 version in this though?

@katmayb
Copy link
Contributor Author

katmayb commented Jun 18, 2025

LGTM - i didn't see the 24.3 version in this though?

TFTR! Ah yes, the mentions I've removed in this PR are not in v24.3 because they're related to whether one should use create logically / create logical replication stream — which isn't in v24.3.

@katmayb katmayb requested a review from rmloveland June 18, 2025 16:14
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FK dependency mention from LDR SQL pages
@katmayb katmayb force-pushed the pcr-fk-dependencies branch from fe91584 to d022309 Compare June 20, 2025 14:56
@katmayb
Copy link
Contributor Author

katmayb commented Jun 20, 2025

TFTRs!

@katmayb katmayb merged commit fae6ffa into main Jun 20, 2025
6 checks passed
@katmayb katmayb deleted the pcr-fk-dependencies branch June 20, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants