Skip to content

Fix buffered writes session var example #19835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-14095

Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit fc4f6a7
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/685db09f4a91b900087116e5

Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit fc4f6a7
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/685db09f5b596b00085e8fa5

Copy link

@rmloveland rmloveland requested a review from stevendanna June 25, 2025 19:32
@rmloveland
Copy link
Contributor Author

@stevendanna context for this PR is that I made a small error in the "how to enable buffered writes" example session var setup which was pointed out in an internal slack message (linked from DOC ticket)

Copy link

netlify bot commented Jun 25, 2025

Netlify Preview

Name Link
🔨 Latest commit fc4f6a7
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/685db09f4d09d70008289b76
😎 Deploy Preview https://deploy-preview-19835--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland rmloveland requested a review from taroface June 25, 2025 21:15
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed a link

@rmloveland
Copy link
Contributor Author

thanks for the reviews!!!

@rmloveland rmloveland enabled auto-merge (squash) June 26, 2025 20:21
@rmloveland rmloveland merged commit 68bbdf9 into main Jun 26, 2025
6 checks passed
@rmloveland rmloveland deleted the 20250625-DOC-14095-fix-buffered-writes-session-var branch June 26, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants