Skip to content

Updates and fixes to PCI DSS topic #19880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

Updates and fixes to PCI DSS topic #19880

merged 4 commits into from
Jul 7, 2025

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Jul 3, 2025

@jhlodin jhlodin requested review from laurenbarker and mikeCRL July 3, 2025 20:54
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit d0beb1a
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/686c12a1b955e90007c2114c

Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit d0beb1a
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/686c12a1291346000828b953

Copy link

netlify bot commented Jul 3, 2025

Netlify Preview

Name Link
🔨 Latest commit d0beb1a
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/686c12a16c7716000865dbaf
😎 Deploy Preview https://deploy-preview-19880--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -28,7 +28,7 @@ Private clusters are not available for [CockroachDB {{ site.data.products.advanc
## Create a private cluster

On GCP, new CockroachDB {{ site.data.products.advanced }} clusters are private by default.
On AWS, newly CockroachDB {{ site.data.products.advanced }} with enhanced security features clusters deployed on AWS are private by default.
On AWS, newly CockroachDB {{ site.data.products.advanced }} with advanced security features clusters deployed on AWS are private by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlodin All Azure cluster are private by default. But one thing to note is that we don't support PCI-DSS on Azure yet

Copy link
Contributor Author

@jhlodin jhlodin Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to hold off on making more edits to this file private-clusters.md specifically, because there is another separate discussion I want to have over use of the seemingly outdated term "private cluster" and whether this doc should continue to exist as-is. See DOC-14194 for more context.

So I'd prefer to leave this untouched for now to avoid scope creep on this PR.

Copy link
Contributor

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few suggestions.

@jhlodin jhlodin enabled auto-merge (squash) July 7, 2025 18:14
@jhlodin jhlodin merged commit 7c8fc2b into main Jul 7, 2025
6 checks passed
@jhlodin jhlodin deleted the jl/doc-14190 branch July 7, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants