-
Notifications
You must be signed in to change notification settings - Fork 470
Updates and fixes to PCI DSS topic #19880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
@@ -28,7 +28,7 @@ Private clusters are not available for [CockroachDB {{ site.data.products.advanc | |||
## Create a private cluster | |||
|
|||
On GCP, new CockroachDB {{ site.data.products.advanced }} clusters are private by default. | |||
On AWS, newly CockroachDB {{ site.data.products.advanced }} with enhanced security features clusters deployed on AWS are private by default. | |||
On AWS, newly CockroachDB {{ site.data.products.advanced }} with advanced security features clusters deployed on AWS are private by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhlodin All Azure cluster are private by default. But one thing to note is that we don't support PCI-DSS on Azure yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to hold off on making more edits to this file private-clusters.md
specifically, because there is another separate discussion I want to have over use of the seemingly outdated term "private cluster" and whether this doc should continue to exist as-is. See DOC-14194 for more context.
So I'd prefer to leave this untouched for now to avoid scope creep on this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A few suggestions.
Addresses points raised in https://cockroachlabs.atlassian.net/browse/DOC-14190