DOC-13899 Product Change- PR #147439 - ui: surface SQL commenter query tags in insights #19897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… corrected SQL CPU Time column name.
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
florence-crl
requested review from
mikeCRL,
angles-n-daemons,
kyle-a-wong and
kevin-v-ngo
and removed request for
mikeCRL
angles-n-daemons
approved these changes
Jul 8, 2025
kyle-a-wong
approved these changes
Jul 10, 2025
kevin-v-ngo
requested changes
Jul 14, 2025
mikeCRL
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Left some suggestions.
Also want to be sure you're aware of the various capitalizations of SQLcommenter: Google's blog uses Sqlcommenter, the repo uses sqlcommenter, and their docs are mixed, often using SQL commenter with a space. Not an easy call which one to use, and I can even see an argument for leaving as SQLcommenter.
kevin-v-ngo
approved these changes
Aug 1, 2025
|
@kevin-v-ngo added a screenshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-13899 DOC-13614
In include file insights.md, (1) added section for Query tags and (2) corrected SQL CPU Time column name.
Rendered preview