Skip to content

Conversation

rmloveland
Copy link
Contributor

Specifically, add the case that strong follower reads can occur under specific conditions even if you are not doing SELECT ... AS OF SYSTEM TIME or reading from a GLOBAL table.

Copy link

netlify bot commented Jul 17, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 3b213ee
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6894fb36aa36ad0008da1d91

Copy link

github-actions bot commented Jul 17, 2025

Copy link

netlify bot commented Jul 17, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 3b213ee
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6894fb36bb92ee00080bf5c3

@rmloveland rmloveland requested a review from stevendanna July 17, 2025 16:12
Copy link

netlify bot commented Jul 17, 2025

Netlify Preview

Name Link
🔨 Latest commit 3b213ee
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6894fb36ee84060008aa99f5
😎 Deploy Preview https://deploy-preview-19953--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland
Copy link
Contributor Author

@stevendanna TFTR! what other versions of CockroachDB would you expect to show this behavior? I would like to backport this change to those versions, if any

@rmloveland rmloveland requested a review from taroface July 25, 2025 16:59
@stevendanna
Copy link
Contributor

@rmloveland I'll have to do some historical git exploration to be 100% confident since the exact set of reads eligible for follow reads has expanded a bit over time. However, my expectation is that some form of this has been available for a long time (i.e. I'm pretty sure this is the behaviour in all supported versions)

@rmloveland
Copy link
Contributor Author

rmloveland commented Jul 29, 2025 via email

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a formatting nit

@rmloveland
Copy link
Contributor Author

@stevendanna ping - any objection to me backporting these changes to v24.1+ ? or would you feel more comfortable v25.1+ ? I'm ok with whatever is ~correct modulo you not needing to do a codebase deep dive (which it seems to me this docs PR is maybe not worth that)

Specifically, add the case that strong follower reads can occur under
specific conditions even if you are not doing `SELECT ... AS OF SYSTEM
TIME` or reading from a `GLOBAL` table.

NB. Backported to all supported versions v25.1+
@rmloveland rmloveland force-pushed the 20250717-update-follower-reads-read-timestamps-behind-closed-timestamp branch from c348559 to a0f6061 Compare August 7, 2025 19:13
@rmloveland
Copy link
Contributor Author

TFTRs!

FYI backported to only the v25.1+ docs for now, if it becomes important to do the more involved spelunking and port to older versions' docs we can do that in another PR

@rmloveland rmloveland enabled auto-merge (squash) August 7, 2025 19:15
@rmloveland rmloveland merged commit 9825210 into main Aug 7, 2025
6 checks passed
@rmloveland rmloveland deleted the 20250717-update-follower-reads-read-timestamps-behind-closed-timestamp branch August 7, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants