Skip to content

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Jul 28, 2025

Fixes DOC-11599

Add task-oriented guidance to our docs around using the cloud API to:

  • View managed backups
  • Restore cluster objects
  • Restore database objects
  • Restore table objects
  • View restore operations on a cluster

Opted to break out our existing include(s) for human readability due to different functionality between Cloud plans.

TODO:

  • Update release note date to the actual release date

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit e001657
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/689a6588e817b8000817b830

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 8dc9fd2
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6887cd19ea6d380007fff9a2

@jhlodin jhlodin requested a review from mikeCRL July 28, 2025 19:20
Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit e001657
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/689a65887eca620007fc954f

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for cockroachdb-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 8dc9fd2
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6887cd19addfc8000839bcc2

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for cockroachdb-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 4610218
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6887cd4d07089d000819c983

Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for cockroachdb-docs failed. Why did it fail? →

Name Link
🔨 Latest commit d662973
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6887d056581dab00085ffc4e

Copy link

netlify bot commented Jul 28, 2025

Netlify Preview

Name Link
🔨 Latest commit e001657
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/689a6588f28be90008e3feda
😎 Deploy Preview https://deploy-preview-20012--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to fix the first link for "Managed backups" in the following section? https://deploy-preview-20012--cockroachdb-docs.netlify.app/docs/cockroachcloud/backup-and-restore-overview#managed-backups
It currently points to the same page. Please make it point to https://deploy-preview-20012--cockroachdb-docs.netlify.app/docs/cockroachcloud/managed-backups
I just realized that it is in an include file as the intro paragraph for the managed-backup pages.

lgtm pending suggestions (mostly nits about verb tense)

Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - left a few notes!

"status": "PENDING",
"created_at": "2025-07-25T16:45:14.064208710Z",
"type": "CLUSTER",
"completion_percent": 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - can we say 100 as that would be 100% completed aka successful?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linhcrl I believe on Intrusion we return a float64 (i.e. 1 instead of 100). Does Console update this to a percentage value?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, we keep it a float between 0 and 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be call fraction_completed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we purposely renamed it for the CC API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be read as the JSON returned immediately to the POST request, wouldn't it show the lowest completion percent?

"status": "PENDING",
"created_at": "2025-07-25T16:45:14.064208710Z",
"type": "CLUSTER",
"completion_percent": 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linhcrl I believe on Intrusion we return a float64 (i.e. 1 instead of 100). Does Console update this to a percentage value?

Copy link

@linhcrl linhcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Let me know if you have any questions. Thanks for putting this together!

"status": "PENDING",
"created_at": "2025-07-25T16:45:14.064208710Z",
"type": "CLUSTER",
"completion_percent": 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, we keep it a float between 0 and 1

@jhlodin jhlodin force-pushed the jl/doc-11599 branch 3 times, most recently from 52ac555 to f99a427 Compare July 31, 2025 02:18
@jhlodin jhlodin force-pushed the jl/doc-11599 branch 3 times, most recently from f737eba to 38bd1c0 Compare August 5, 2025 19:42
@jhlodin
Copy link
Contributor Author

jhlodin commented Aug 5, 2025

@laurenbarker @alicia-l2 From the sync, open questions for the docs are:

  • Do we need to add a "do not hit this endpoint more than X" note to listBackups?
  • Are we launching this in preview or GA as originally planned?
  • Do we need to yank listBackups out of this so we can ship restore ASAP?

Also I added a draft release note, PTAL. Date to be updated whenever we release.

@alicia-l2
Copy link

@laurenbarker @alicia-l2 From the sync, open questions for the docs are:

  • Do we need to add a "do not hit this endpoint more than X" note to listBackups?
  • Are we launching this in preview or GA as originally planned?
  • Do we need to yank listBackups out of this so we can ship restore ASAP?

Also I added a draft release note, PTAL. Date to be updated whenever we release.

No, let's not add that note.
We are launching in Limited Access
No, we don't need to yank Listbackups out.

reviewed release note as well, had a small nit.

Not sure if you've started the draft language for the limited access but here is what kathryn put for PCR, which we can do something similar for this:

"Note:
This feature is in limited access and is only available to enrolled organizations. To enroll your organization, contact your Cockroach Labs account team. This feature is subject to change."

Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final changes LGTM, thank you!

@jhlodin jhlodin merged commit 39e2eb5 into main Aug 12, 2025
5 checks passed
@jhlodin jhlodin deleted the jl/doc-11599 branch August 12, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants