Skip to content

CITEXT known limitation #20060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 4, 2025
Merged

CITEXT known limitation #20060

merged 5 commits into from
Aug 4, 2025

Conversation

taroface
Copy link
Contributor

@taroface taroface commented Aug 4, 2025

@taroface taroface requested a review from paulniziolek August 4, 2025 14:18
@netlify Netlify
Copy link

netlify bot commented Aug 4, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit dc3b538
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6891192ba69b7400084d0355

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

Files changed:

@netlify Netlify
Copy link

netlify bot commented Aug 4, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit dc3b538
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6891192b1ab5c300084177e6

@netlify Netlify
Copy link

netlify bot commented Aug 4, 2025 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit dc3b538
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6891192bb9c9a40008d00b72
😎 Deploy Preview https://deploy-preview-20060--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

paulniziolek
paulniziolek reviewed Aug 4, 2025
View reviewed changes
src/current/_includes/v25.3/known-limitations/citext-limitations.md Outdated
@@ -0,0 +1 @@
- `CITEXT` types are not compatible with the `LIKE` and `ILIKE` operators. [#149791](https://github.com/cockroachdb/cockroach/issues/149791)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: maybe indicate "CITEXT types are not yet compatible with ...", as LIKE and ILIKE are meant to be supported in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll say "currently" as "yet" implies more of a promise -- we want to avoid those in docs!

paulniziolek
paulniziolek approved these changes Aug 4, 2025
View reviewed changes
Copy link

@paulniziolek paulniziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@taroface taroface requested a review from florence-crl August 4, 2025 15:18
florence-crl
florence-crl approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taroface taroface enabled auto-merge (squash) August 4, 2025 15:54
@taroface taroface merged commit c10a8dc into main Aug 4, 2025
5 checks passed
@taroface taroface deleted the citext-known-limitation branch August 4, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florence-crl florence-crl florence-crl approved these changes

+1 more reviewer

@paulniziolek paulniziolek paulniziolek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taroface @paulniziolek @florence-crl