Skip to content

Conversation

taroface
Copy link
Contributor

@taroface taroface commented Aug 20, 2025

Relates to DOC-14618

  • Move Markdown syntax guidance to a new doc, MarkdownGuide.md
    • Update Markdown guidance, especially for links
  • Consolidate some Style Guide sections with overlapping or redundant guidance
  • Remove nonexistent section headings from Style Guide TOC

@taroface taroface requested a review from florence-crl August 20, 2025 16:53
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 383d1d6
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68a77a1b5f7a4e0008140b78

Copy link

netlify bot commented Aug 20, 2025

Netlify Preview

Name Link
🔨 Latest commit 383d1d6
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68a77a1b3b827a0008fd85aa
😎 Deploy Preview https://deploy-preview-20170--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 383d1d6
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68a77a1bc663510008316a88

Copy link

Files changed:

  • MarkdownGuide.md
  • StyleGuide.md

@taroface taroface requested a review from Flat5flat9 August 20, 2025 16:56
@taroface taroface force-pushed the style-guide-refactor branch from ecbde50 to c3a791c Compare August 20, 2025 17:04
~~~markdown
[Link text](https://example.com)
~~~
If the page is versioned, use `{{ page.version.version }}` rather than the hardcoded version. Exceptions apply when linking to versioned pages from [non-versioned pages](#links-to-versioned-docs-pages-from-a-non-versioned-directory) and [technical advisory pages](#links-to-cockroachdb-docs-from-technical-advisories).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably fine, but for me it opens up a can of worms around why we version some pages and not others, and if the designation changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All docs pertaining to the CRDB binary are versioned. Docs for CockroachDB Cloud and MOLT aren't versioned because they're not beholden to the CRDB versioning. So it's a structural decision that reflects the product rather than a subjective one, IMO. Let me know if it seems worth spelling this out in the style guide, though.

#### HTML

If it's necessary to include more complex table formatting or if a [Markdown table](#markdown) becomes too unwieldy, create a table using HTML. This formatting is not recommended unless necessary, since it is hard for other writers to parse and maintain.
## Content elements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel like the link at the top of this doc pointing folks to the markdown guide makes keeping this section around unnecessary

PS I absolutely love this PR, thank you for writing it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that a lot more content should go in the Markdown Guide, so i moved this and more stuff over there!

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending suggestions.

I was not able to add this suggestion:
In StyleGuide.md, line 444, please remove the section link to #code-blocks


Use tables to display structured information in an easy-to-read format. We use two types of tables: [Markdown](#markdown-tables) and [HTML](#html-tables).

### Markdown tables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhere in this section, you may want to include the alignment guidance mentioned in this slack thread

@taroface taroface enabled auto-merge (squash) August 21, 2025 19:57
@taroface taroface merged commit 8d6aeb3 into main Aug 21, 2025
6 checks passed
@taroface taroface deleted the style-guide-refactor branch August 21, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants