swiss: allow building with go1.23 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
|
TFTR! |
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Jun 5, 2024
Add `runtime_go1.23.go` and remove `!go1.23` build tag in the pebble dependency [1], [2], [3], in order to enable `go build...` with an unreleased version of Go 1.23 (i.e., from `master`). [1] cockroachdb/swiss#35 [2] cockroachdb/pebble#3645 [3] cockroachdb#125147 Epic: none Informs: cockroachdb#125104 Release note: None
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Jun 6, 2024
Add `runtime_go1.23.go` and remove `!go1.23` build tag in the pebble dependency [1], [2], [3], in order to enable `go build...` with an unreleased version of Go 1.23 (i.e., from `master`). [1] cockroachdb/swiss#35 [2] cockroachdb/pebble#3645 [3] cockroachdb#125147 Epic: none Informs: cockroachdb#125104 Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jun 6, 2024
125105: build: prepare for Go 1.23 r=RaduBerinde a=srosenberg Add `runtime_go1.23.go` and remove `!go1.23` build tag in the pebble dependency [1], [2], [3], in order to enable `go build...` with an unreleased version of Go 1.23 (i.e., from `master`). [1] cockroachdb/swiss#35 [2] cockroachdb/pebble#3645 [3] #125147 Epic: none Informs: #125104 Release note: None Co-authored-by: Stan Rosenberg <[email protected]>
Dhruv-Sachdev1313
pushed a commit
to Dhruv-Sachdev1313/cockroach
that referenced
this pull request
Jun 7, 2024
Add `runtime_go1.23.go` and remove `!go1.23` build tag in the pebble dependency [1], [2], [3], in order to enable `go build...` with an unreleased version of Go 1.23 (i.e., from `master`). [1] cockroachdb/swiss#35 [2] cockroachdb/pebble#3645 [3] cockroachdb#125147 Epic: none Informs: cockroachdb#125104 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for [1]. No issues building with Go from
master,although I haven't tested extensively.
[1] cockroachdb/cockroach#125104