Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses ndk r16 to re-compile SpiderMonkey v33 #4

Merged
merged 19 commits into from
Dec 15, 2017

Conversation

dumganhar
Copy link

@dumganhar dumganhar commented Nov 27, 2017

No description provided.

@@ -91,7 +99,7 @@ toolchain-default|"")
arch_flag=""
;;
*)
arch_flag="-march=$MOZ_ARCH"
arch_flag=""
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should only modify for android, don't affect other platforms.

James Chen added 5 commits November 27, 2017 18:44
AC_TYPE_XXX macros aren't supported by ndk r16 since it will cause test failure
by a linking error like the following line, so disable it for android only.
crtbegin_dynamic.o:crtbegin.c:function _start: error: undefined reference to 'main'
@dumganhar dumganhar changed the title Uses ndk r16b to re-compile SpiderMonkey v33 Uses ndk r16 to re-compile SpiderMonkey v33 Nov 28, 2017
@@ -1559,7 +1559,7 @@ ia64*-hpux*)
TARGET_NSPR_MDCPUCFG='\"md/_linux.cfg\"'

MOZ_GFX_OPTIMIZE_MOBILE=1
MOZ_OPTIMIZE_FLAGS="-O3 -freorder-blocks -fno-reorder-functions"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-freorder-blocks -fno-reorder-functions were deprecated by clang.

http://code.alaminium.me/habibalamin/homebrew/commit/6a0110a4ff0ad15735f5a39c1897306bc4ee27bb

@minggo minggo merged commit 1d8c1d7 into cocos2d:v33 Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants