Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AssumeRoleTokenProvider #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bkeelan
Copy link

@bkeelan bkeelan commented May 10, 2021

Currently this tooling does not allow for using an aws profile that assumes a role with mfa enabled.

$ helm ssm -d -v -p staging -f values.yaml
panic: AssumeRoleTokenProviderNotSetError: assume role with MFA enabled, but AssumeRoleTokenProvider session option not set.

Adding the AssumeRoleTokenProvider allows for this functionality

After you've updated your shared configuration file, you can update your application code's Sessions to specify how the MFA token code is retrieved from your application's users. If a shared configuration profile specifies a role to assume, and the mfa_serial field is provided, the SDK requires that the AssumeRoleTokenProvider session option is also set. There's no harm in always setting the AssumeRoleTokenProvider session for applications that will always be run by a person. The field is only used if the shared configuration's profile has a role to assume, and then sets the mfa_serial field. Otherwise, the option is ignored.

$ helm ssm -d -v -p staging -f values.yaml
Assume Role MFA token code: 833369
service:
ingress:
  enabled: false
  hosts:
    - service.helm-test-tag

@jkranking
Copy link

@lolgab @pedrocodacy @rtfpessoa

We'd love to leverage the helm-ssm plugin with our team's helm dev flow with this small mfa change from @bkeelan. Any chance you guys can take a look so we don't have to fork?

Thanks!

@pedrocodacy pedrocodacy requested a review from h314to July 13, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants