Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text contrast for hover and focus examples in light mode #493

Conversation

87xie
Copy link
Contributor

@87xie 87xie commented Dec 25, 2024

Hi there, thanks for the great work! I noticed that the code mention and focus examples have low text contrast in light mode, so I created a fix for it. Feel free to close this if I missed something obvious.

Before

image

image

After

image

image

Copy link

vercel bot commented Dec 25, 2024

@87xie is attempting to deploy a commit to the codehike Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

No changeset detected. If you are changing codehike click here to add a changeset.

@87xie 87xie changed the title docs: improve text contrast for hover and focus examples in light mode Improve text contrast for hover and focus examples in light mode Dec 25, 2024
Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codehike.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 0:46am

@pomber
Copy link
Contributor

pomber commented Dec 26, 2024

Thanks!

@pomber pomber merged commit f9781e0 into code-hike:next Dec 26, 2024
4 checks passed
@87xie 87xie deleted the improve-text-contrast-for-hover-and-focus-examples-in-light-mode branch December 26, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants