[pull] master from getsentry:master #3337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…94924) The normal mode should be the default since it avoids timeouts better. All of the frontend uses the progressive query or they specify `NORMAL` mode. This allows us to clean up the code and assume normal mode by default, to remove any explicit passing down when unnecessary. Afaik no request requires `HIGH_ACCURACY` from the beginning by explicitly omitting the `samplingMode` param.
…#94925) The helper does a feature flag check to invalidate the correct key since the URLs are different. Fixes the scenario where the sidebar is in its dynamic state, you rearrange, and when you hover out and back onto the dashboards list, the dashboards should be in the new order. They were in the old order because we didn't invalidate the cache with the new query key. After the feature flag gets removed I'll just hardcode the query key instead of exporting it/getting it through the helper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.2)
Can you help keep this open source service alive? 💖 Please sponsor : )