Skip to content

Quiz #2 - To be clearer than Ayende #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2014
Merged

Quiz #2 - To be clearer than Ayende #6

merged 2 commits into from
Jul 22, 2014

Conversation

arialdomartini
Copy link
Contributor

The quiz

Here is a snipped of code I copied from @ayende's RavenDB repository

Find the original code here

The if to be remove is pretty trivial

public void EnsureHasField(string ensuredFieldName)
{
    if (ensuredFieldNames == null)
        ensuredFieldNames = new HashSet<string>();
    ensuredFieldNames.Add(ensuredFieldName);
}

I added a .net solution, with a simple build script in PowerShell, which will download the dependencies with NuGet and will run the tests with nUnit (@naighes, I'm looking forward to see a pull request with a switch to xUnit).

Come on! Can you remove this if?

arialdomartini added a commit that referenced this pull request Jul 22, 2014
Quiz #2 - To be clearer than Ayende
@arialdomartini arialdomartini merged commit 86af095 into code4nothing:master Jul 22, 2014
@arialdomartini
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant