Use alwaysComputeGreedyQ for recurrent

codeaudit · Jun 27, 2016 · 2224b8a · 2224b8a
1 parent 626712b
commit 2224b8a
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/async/QAgent.lua b/async/QAgent.lua
@@ -20,7 +20,6 @@ function QAgent:_init(opt, policyNet, targetNet, theta, targetTheta, atomic, sha
   self.dTheta:zero()
 
   self.doubleQ = opt.doubleQ
-  self.recurrent = opt.recurrent
 
   self.epsilonStart = opt.epsilonStart
   self.epsilon = self.epsilonStart
@@ -34,7 +33,8 @@ function QAgent:_init(opt, policyNet, targetNet, theta, targetTheta, atomic, sha
   self.tic = 0
   self.step = 0
 
-  self.alwaysComputeGreedyQ = not self.doubleQ
+  -- Forward state anyway if recurrent
+  self.alwaysComputeGreedyQ = opt.recurrent or not self.doubleQ
 
   self.QCurr = torch.Tensor(0)
 end
@@ -61,10 +61,6 @@ function QAgent:eGreedy(state, net)
   end
 
   if torch.uniform() < self.epsilon then
-    -- Forward state anyway if recurrent
-    if self.recurrent then
-      net:forward(state)
-    end
     return torch.random(1,self.m)
   end