Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon ADM #38

Merged
merged 11 commits into from
Nov 5, 2016
Merged

Amazon ADM #38

merged 11 commits into from
Nov 5, 2016

Conversation

talklittle
Copy link
Contributor

No description provided.

@hpopp
Copy link
Member

hpopp commented Oct 24, 2016

Thank you so much for this! I've been out of town for the past several days but I'll take a closer look when I get back. At the moment pigeon is stuck at its current version on hex because of its recent policy change regarding github dependencies. When I resolve it, I'll roll this in with those changes in a v0.10.0 release.

I'm not entirely familiar with ADM and haven't ever used it in a project. Would you mind taking responsibility for maintaining this functionality moving forward?

@talklittle
Copy link
Contributor Author

@hpopp Cool thanks. Sure, I'll maintain the functionality, since I expect to continue using Pigeon for push notifications, as well as continuing to support Amazon Android devices. I'll let you know if that ever has to change.

@hpopp hpopp merged commit e641629 into codedge-llc:master Nov 5, 2016
@talklittle talklittle deleted the amazon-adm branch November 5, 2016 19:01
@hpopp
Copy link
Member

hpopp commented Nov 5, 2016

Everything checked out great! With luck there will be a release out on hex this weekend.

A bit of a heads up, there's going to be a change in the config style. APNS will be supporting multiple worker pools, so each APNS, GCM and ADM will each get their own config blocks.

The new ADM one will look something like:

 config :pigeon, :adm,
  client_id: "client id here",
  client_secret: "client secret here"

Don't worry about unit tests. I should probably be able to update them myself.

@talklittle
Copy link
Contributor Author

Awesome! Thanks a lot!

@talklittle talklittle restored the amazon-adm branch November 17, 2016 05:25
cstar pushed a commit to cstar/pigeon that referenced this pull request Jan 3, 2017
* ADM: configure Supervisor

* ADM: Pigeon.ADM module, push/1 and push/2

* ADM: refresh access token

* ADM: Notification struct

* ADM: send push request

* ADM: handle response

* ADM: convert error to atom

* ADM: calculate payload data MD5

* ADM: dev config

* ADM: ensure data keys/values are strings

* ADM: update README.md
@talklittle talklittle deleted the amazon-adm branch July 6, 2017 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants