Add priority option for GCM #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't forgotten, just forgot to reply! I do intend to include this in |
|
Sure, sounds great! You can ping me when the other GCM PR is merged, I can then fix/update this one :) |
fixed encode_requests for multiple registration ids
|
FCM functionality pushed to master. Still have some things left to tweak before a hex release, but if you'd like to pull changes and fix up this PR I'll merge it in. |
|
@hpopp Sorry it took so long, but I finally found the time to update this. Please tell me what you think :) |
|
Also, let me know if you would like me to squash all the commits into one |
|
Looks good! I was able to squash in the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developers.google.com/cloud-messaging/concept-options#setting-the-priority-of-a-message
I think there is no option to set priority at the moment and it's quite an important feature. Please let me know what you think. If you're ok with the implementation, I'll add some information about it to the docs.