Feature/surround with monitor action #223
Conversation
client/src/editor.ts
Outdated
| return true; | ||
| } | ||
| else { | ||
| for (let i = currentLine; i < document.lineCount; i++) { |
There was a problem hiding this comment.
I am not sure about this check. In modern versions of RPGLE (7.3+), /free and /end-free are optional, so if they're not used, then it might always return false by the looks of it.
client/src/editor.ts
Outdated
| if (editor) { | ||
| const document = editor.document; | ||
| let line = editor.selection.start.line; | ||
| if (isFreeRPGLE(document, line)) { |
There was a problem hiding this comment.
This logic is interesting, checking if the logic is currently free format. Perhaps instead if the document is not **free, substring the first 8(?) characters and then surround that? That might be nicer than checking for /free and /end-free.
|
Pretty good feedback @worksofliam , thanks! |
|
This is a truly late reply, but...
Because |
Changes
Inspired by this discussion: https://github.com/orgs/halcyon-tech/discussions/1345
Added an
RPGLEsubmenu and aSurround with monitoraction for rpgle editors.Surrounding will be allowed only for Free RPGLE code. Fixed RPG or mixed RPG will show a warning.
The action will surround the code, based on:
The current cursor position
The current selection
It's not necessary to select the entire code. The action will select the whole line(s).
Checklist