-
Notifications
You must be signed in to change notification settings - Fork 56
Fix/kubernetes devcontainer template to require fewer updates on initial deployment #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/kubernetes devcontainer template to require fewer updates on initial deployment #386
Conversation
…it auth and fixed container security context which will always need to be privileged on majority of K8S deployments
…pu parameter icon reference
# Note: May not work on AWS Linux Nodes | ||
# metadata { | ||
# display_name = "CPU Usage" | ||
# key = "0_cpu_usage" | ||
# script = "coder stat cpu" | ||
# interval = 10 | ||
# timeout = 1 | ||
# } | ||
# Note: May not work on AWS Linux Nodes | ||
# metadata { | ||
# display_name = "RAM Usage" | ||
# key = "1_ram_usage" | ||
# script = "coder stat mem" | ||
# interval = 10 | ||
# timeout = 1 | ||
# } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Note: May not work on AWS Linux Nodes | |
# metadata { | |
# display_name = "CPU Usage" | |
# key = "0_cpu_usage" | |
# script = "coder stat cpu" | |
# interval = 10 | |
# timeout = 1 | |
# } | |
# Note: May not work on AWS Linux Nodes | |
# metadata { | |
# display_name = "RAM Usage" | |
# key = "1_ram_usage" | |
# script = "coder stat mem" | |
# interval = 10 | |
# timeout = 1 | |
# } | |
# Note: May not work on AWS Linux Nodes | |
metadata { | |
display_name = "CPU Usage" | |
key = "0_cpu_usage" | |
script = "coder stat cpu" | |
interval = 10 | |
timeout = 1 | |
} | |
# Note: May not work on AWS Linux Nodes | |
metadata { | |
display_name = "RAM Usage" | |
key = "1_ram_usage" | |
script = "coder stat mem" | |
interval = 10 | |
timeout = 1 | |
} |
@greg-the-coder Would it maybe be worth just adding the Note and leaving the stats. Since not all people would be using kubernetes with aws?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
70%+ of our enterprise, paying customers run Coder on AWS. Also, I ran into the same issue when working with the SUSE/Rancher folks earlier in the year when I was helping them prep a Devcontainer demo for SUSECON. I would prefer to leave that commented out, and then someone could uncomment it if they wanted it, so it at least works out of the box. What I'm seeing in the field on a couple of the customer POVs I've shadowed is the reverse, where we have to walk customers through "tweaking" the templates before they work, which isn't ideal.
Description
Identified changes to template so that it can be used "out of the box" with fewer updates across a wider variety of coder deployments. Tested on base AWS EKS cluster that used AWS Linux/Bottlerocket node group.
Type of Change
Testing & Validation
bun test
)bun run fmt
)Related Issues
None