-
Notifications
You must be signed in to change notification settings - Fork 55
feat(claude-code): add subdomain variable and logic #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces subdomain routing support for the Claude Code module, allowing users to choose between subdomain and path-based routing. The changes enhance the module's flexibility while maintaining backward compatibility.
- Added
subdomain
variable to control routing method (subdomain vs. path-based) - Updated AgentAPI version from v0.3.0 to v0.3.3 to support required environment variable configuration
- Implemented conditional logic for base paths and environment variables based on subdomain setting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
main.tf | Added subdomain variable, conditional path logic, and updated AgentAPI version |
README.md | Updated version references from 2.1.0 to 2.2.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me, but it's a shame it's getting duplicated here - it's already present in the agentapi module.
It's high time we migrated the claude code module to use the agentapi module - the divergence is getting hard to manage.
I haven't tested this locally, so please make sure it works before merging.
It's on list the list @hugodutka. |
I tested this locally with and without the subdomain option to verify it works and that it doesn't break any existing templates, and it was working perfectly. |
@DevelopmentCats Lets merge and unblock @greg-the-coder |
Closes #
Description
subdomain
variableTested with and without subdomain to ensure no breaking changes
Type of Change
Module Information
Path:
registry/coder/modules/claude-code
New version:
v2.2.0
Breaking change: [X] Yes [ ] No
Testing & Validation
bun test
)bun run fmt
)Related Issues