Skip to content

Conversation

DevelopmentCats
Copy link
Contributor

@DevelopmentCats DevelopmentCats commented Aug 26, 2025

Description

  • Introduces mcp file creation via coder_script in kiro and windsurf modules
  • Add mcp variable to both modules
  • Add slug and display_name variables to windsurf to match up with other modules
  • Add tests for testing mcp file creation for both kiro and windsurf

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/kiro
New version: v1.1.0
Breaking change: [ ] Yes [X] No

Path: registry/coder/modules/windsurf
New version: v1.2.0
Breaking change: [ ] Yes [X] No

Path: registry/coder/modules/cursor
New version: v1.3.2
Breaking change: [ ] Yes [X] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 14:49
@DevelopmentCats DevelopmentCats marked this pull request as draft August 26, 2025 14:50
@DevelopmentCats
Copy link
Contributor Author

Testing these modules and then I will move out of draft

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds MCP (Model Context Protocol) file creation functionality to both the kiro and windsurf Coder modules. It enables these modules to create MCP configuration files when a JSON configuration is provided via a new mcp variable.

  • Adds MCP configuration support through new mcp variables and coder_script resources
  • Standardizes windsurf module variables by adding slug and display_name variables to match other modules
  • Includes comprehensive test coverage for the new MCP file creation functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
registry/coder/modules/windsurf/main.tf Adds mcp variable, slug/display_name variables, and coder_script for MCP file creation
registry/coder/modules/windsurf/main.test.ts Adds test for MCP configuration file creation
registry/coder/modules/windsurf/README.md Updates version references from 1.1.1 to 1.2.0
registry/coder/modules/kiro/main.tf Adds mcp variable and coder_script for MCP file creation
registry/coder/modules/kiro/main.test.ts Adds test for MCP configuration file creation
registry/coder/modules/kiro/README.md Updates version references from 1.0.0 to 1.1.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DevelopmentCats DevelopmentCats marked this pull request as ready for review August 26, 2025 16:22
bpmct
bpmct previously approved these changes Aug 26, 2025
@bpmct
Copy link
Member

bpmct commented Aug 26, 2025

Awesome!

@matifali matifali self-requested a review August 26, 2025 17:04
matifali
matifali previously approved these changes Aug 26, 2025
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@matifali
Copy link
Member

@DevelopmentCats lets also set file permissions as per https://kiro.dev/docs/mcp/security/

@DevelopmentCats DevelopmentCats dismissed stale reviews from matifali and bpmct via 3dd1036 August 26, 2025 20:17
@DevelopmentCats
Copy link
Contributor Author

@DevelopmentCats lets also set file permissions as per https://kiro.dev/docs/mcp/security/

Would you prefer this for all of the modules (cursor, kiro, windsurf) to do this or just kiro like I have commit above?

@matifali
Copy link
Member

@DevelopmentCats All

matifali
matifali previously approved these changes Aug 26, 2025
@matifali matifali changed the title feat: add mcp file creation for kiro and windsurf modules feat: add mcp config for kiro and windsurf modules Aug 26, 2025
@DevelopmentCats DevelopmentCats merged commit 9125a52 into main Aug 27, 2025
6 of 7 checks passed
@DevelopmentCats DevelopmentCats deleted the cat/windsurf-kiro-mcp branch August 27, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants