Skip to content

chore: Fixed path to avatar #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2025
Merged

chore: Fixed path to avatar #400

merged 3 commits into from
Aug 28, 2025
+0 −0

Conversation

lucashkaplan
Copy link
Contributor

This PR fixes a path issue in the README of the AJ0070 profile. The original avatar path had the wrong extension.

@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 21:26
Copilot
Copilot AI reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the avatar image file extension in the AJ0070 profile README from .png to .jpeg to match the actual file format.

  • Fixed avatar path extension from .png to .jpeg

@lucashkaplan lucashkaplan self-assigned this Aug 28, 2025
@lucashkaplan lucashkaplan changed the title Fixed path to avatar chore: Fixed path to avatar Aug 28, 2025
bcpeinhardt
bcpeinhardt previously approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@bcpeinhardt bcpeinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the annoying things about the build process relying on git branches is I don't have any way to preview this in the UI :/

@bcpeinhardt
Copy link
Collaborator

Actually this would fail the check, not sure how to revoke approval.

@bcpeinhardt
Copy link
Collaborator

They need to provide a new avatar image:

registry/CONTRIBUTING.md

Line 53 in 35e64f2

- **Namespace avatars**: Must be named `avatar.png` or `avatar.svg` in `/registry/[namespace]/.images/`

@bcpeinhardt bcpeinhardt self-requested a review August 28, 2025 21:39
@bcpeinhardt bcpeinhardt dismissed their stale review August 28, 2025 21:40

Missed a requirement in the contributing docs

@bcpeinhardt bcpeinhardt enabled auto-merge (squash) August 28, 2025 22:32
@bcpeinhardt bcpeinhardt merged commit 901043b into main Aug 28, 2025
6 of 7 checks passed
@bcpeinhardt bcpeinhardt deleted the lucas/image_path_fix branch August 28, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Parkreiner Parkreiner Parkreiner approved these changes

@bcpeinhardt bcpeinhardt bcpeinhardt approved these changes

Assignees

@lucashkaplan lucashkaplan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucashkaplan @bcpeinhardt @Parkreiner