refactor: introduce Source base class

[NicolasIRAGNE]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces a Source base class and refactors the filesystem schema to use proper inheritance and polymorphism. The refactoring eliminates the enum-based type system in favor of specialized classes for different filesystem node types.

Key changes:

• Introduces a new Source base class with common fields (metadata and extra)
• Replaces FileSystemNodeType enum with specialized classes (FileSystemFile, FileSystemDirectory, FileSystemSymlink, GitRepository)
• Moves type-specific behavior into polymorphic methods on the respective classes

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/gitingest/schemas/source.py	New base class with common metadata fields
src/gitingest/schemas/filesystem.py	Major refactor replacing enum-based typing with inheritance hierarchy
src/gitingest/schemas/__init__.py	Updated exports to include new classes
src/gitingest/output_formatter.py	Updated to use polymorphic methods instead of type checking
src/gitingest/ingestion.py	Updated to instantiate specific node types instead of generic nodes
.vscode/launch.json	Added reload flag to debug configuration

[Copilot]

The comment '# Default: not a file' is unclear. Consider documenting the actual priority values and what they represent (e.g., '# Default priority for non-file nodes (directories, symlinks)').

Suggested change

	"""Return sort priority. Override in subclasses."""
	return 1 # Default: not a file
	"""Return sort priority. Override in subclasses.
	Returns
	-------
	int
	Sort priority value. By convention:
	0 - file nodes (highest priority, e.g., README)
	1 - default for non-file nodes (directories, symlinks, etc.)
	Subclasses should override as appropriate.
	"""
	return 1 # Default priority for non-file nodes (directories, symlinks, etc.)

[Copilot]

Imports inside methods can impact performance and readability. Consider moving these imports to the top of the file or module level.

Suggested change

	from gitingest.utils.file_utils import _decodes, _get_preferred_encodings, _read_chunk
	from gitingest.utils.notebook import process_notebook
	from gitingest.utils.notebook import process_notebook

[Copilot]

Imports inside methods can impact performance and readability. Consider moving these imports to the top of the file or module level.

Suggested change

from gitingest.utils.notebook import process_notebook

[Copilot]

Calling self.content in summary info will trigger file reading, which could be expensive. Consider caching content or only reading when actually needed for display.

Suggested change

	return f"File: {self.name}\nLines: {len(self.content.splitlines()):,}\n"
	def is_single_file(self) -> bool:
	"""Files are single files."""
	return True
	def render_tree(self, prefix: str = "", *, is_last: bool = True) -> list[str]:
	"""Render the tree representation of this file."""
	current_prefix = "└── " if is_last else "├── "
	return [f"{prefix}{current_prefix}{self.name}"]
	if self._cached_content is not None:
	line_count = len(self._cached_content.splitlines())
	return f"File: {self.name}\nLines: {line_count:,}\n"
	else:
	return f"File: {self.name}\nLines: (not loaded)\n"
	def is_single_file(self) -> bool:
	"""Files are single files."""
	return True
	@property
	def content(self) -> str:
	"""Return file content, caching after first read."""
	if self._cached_content is None:
	self._cached_content = self.get_content()
	return self._cached_content

[Copilot]

Using hasattr check for children is unnecessary since children is defined as a field with default factory in the base class. This check can be simplified to just if self.children:.

Suggested change

	if hasattr(self, "children") and self.children:
	if self.children:

[Copilot]

Using hasattr check for children is unnecessary since children is defined as a field with default factory in the base class. This check can be simplified to just if self.children:.

Suggested change

	if hasattr(self, "children") and self.children:
	if self.children: