This repository has been archived by the owner on Dec 31, 2021. It is now read-only.
Minor tweaks #11
Closed
Minor tweaks #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove readme from long_description since Opscode says this isn't necessary and is ignored by Chef 11. Add name to the metadata, which is a requirement in Chef 11. Change mode defs from strings to ints.
| @@ -23,7 +23,7 @@ | |||
| directory node[:collectd][:collectd_web][:path] do | |||
| owner "root" | |||
| group "root" | |||
| mode "755" | |||
| mode 00755 | |||
There was a problem hiding this comment.
I am very against using octal numbers for modes, it is error prone even at the best of times.
|
I pulled in the name fix, the rest I won't merge. |
danryan
pushed a commit
to danryan/chef-collectd
that referenced
this pull request
Apr 18, 2013
Use the newest write_graphite plugin, and always fallback to 127.0.0.1 if no other graphite server was found
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove readme from long_description since Opscode says this isn't
necessary and is ignored by Chef 11. Add name to the metadata, which
is a requirement in Chef 11. Change mode defs from strings to ints.