Use tmp file instead of writing to current directory

coderanger · Jan 12, 2017 · 50c8780 · 50c8780
1 parent 122c687
commit 50c8780
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/php/bin/generate_proto_php.sh b/src/php/bin/generate_proto_php.sh
@@ -39,12 +39,13 @@ protoc --proto_path=src/proto/math \
 
 # replace the Empty message with EmptyMessage
 # because Empty is a PHP reserved word
+output_file=$(mktemp)
 sed 's/message Empty/message EmptyMessage/g' \
-  src/proto/grpc/testing/empty.proto > empty.proto
-mv empty.proto ./src/proto/grpc/testing
+  src/proto/grpc/testing/empty.proto > $output_file
+mv $output_file ./src/proto/grpc/testing/empty.proto
 sed 's/grpc\.testing\.Empty/grpc\.testing\.EmptyMessage/g' \
-  src/proto/grpc/testing/test.proto > test.proto
-mv test.proto ./src/proto/grpc/testing
+  src/proto/grpc/testing/test.proto > $output_file
+mv $output_file ./src/proto/grpc/testing/test.proto
 
 protoc --proto_path=. \
        --php_out=src/php/tests/interop \
@@ -56,9 +57,9 @@ protoc --proto_path=. \
 
 # change it back
 sed 's/message EmptyMessage/message Empty/g' \
-  src/proto/grpc/testing/empty.proto > empty.proto
-mv empty.proto ./src/proto/grpc/testing
+  src/proto/grpc/testing/empty.proto > $output_file
+mv $output_file ./src/proto/grpc/testing/empty.proto
 sed 's/grpc\.testing\.EmptyMessage/grpc\.testing\.Empty/g' \
-  src/proto/grpc/testing/test.proto > test.proto
-mv test.proto ./src/proto/grpc/testing
+  src/proto/grpc/testing/test.proto > $output_file
+mv $output_file ./src/proto/grpc/testing/test.proto