Skip to content

Commit

Permalink
Add a comment explaining the Popen change
Browse files Browse the repository at this point in the history
  • Loading branch information
murgatroid99 committed Sep 18, 2020
1 parent 0013616 commit f6057e0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/run_tests/run_xds_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -1800,6 +1800,7 @@ def __init__(self, compute, alpha_compute, project):
metadata_to_send=metadata_to_send)
logger.debug('running client: %s', client_cmd_formatted)
try:
# We invoke the client using bash to avoid https://github.com/nvm-sh/nvm/issues/1866
client_process = subprocess.Popen(['/bin/bash', '-i', '-c', client_cmd_formatted],
env=client_env,
stderr=subprocess.STDOUT,
Expand Down

0 comments on commit f6057e0

Please sign in to comment.