Add pagination to get_workflow_history #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeRauk
reviewed
Apr 6, 2024
lib/temporal/client.rb
Outdated
|
|
||
| Workflow::History.new(history_response.history.events) | ||
| Workflow::History.new(response.history.events) |
There was a problem hiding this comment.
Did you mean to create the workflow history object from the events property? Creating it from response.history.events is incorrect.
|
Hey! Just checking in on this PR. @DeRauk, @cduanfigma addressed the comments you left. Is there anything else we should do to get this merged? |
|
@cj-cb could you take a look at this one? |
|
@cduanfigma Thank you for the PR. Can you please resolve the conflicts? |
|
@cj-cb conflicts are resolved! |
cj-cb
approved these changes
Jul 17, 2024
|
@cduanfigma Looks like tests are failing. Do you mind pulling in the latest in master again to get a fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses pagination in
get_workflow_historyso that it fetches the complete history result.Review without whitespace.
Fixes #289