Standardize MemoryPoolAllocator::Realloc() also, and improve coverage

colindj · May 3, 2015 · 1c98609 · 1c98609
1 parent ae61b79
commit 1c98609
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/include/rapidjson/allocators.h b/include/rapidjson/allocators.h
@@ -189,6 +189,9 @@ class MemoryPoolAllocator {
         if (originalPtr == 0)
             return Malloc(newSize);
 
+        if (newSize == 0)
+            return NULL;
+
         // Do not shrink if new size is smaller than original
         if (originalSize >= newSize)
             return originalPtr;

diff --git a/test/unittest/allocatorstest.cpp b/test/unittest/allocatorstest.cpp
@@ -42,6 +42,9 @@ void TestAllocator(Allocator& a) {
         EXPECT_EQ(i, r[i]);
 
     Allocator::Free(r);
+
+    // Realloc to zero size
+    EXPECT_TRUE(a.Realloc(a.Malloc(1), 1, 0) == 0);
 }
 
 TEST(Allocator, CrtAllocator) {