Remove duplicated spinner #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is the right way to fix it; the spinner is duplicated, so probably we don't need to redeclare it in this package. |
|
@hvelarde it is true for Plone 4.3.x, but for Plone 5.x we will miss the spinner if I remove it |
hvelarde
requested changes
Mar 3, 2017
|
Ok, let's start again :) |
rodfersou
commented
Mar 3, 2017
| @@ -140,6 +140,8 @@ | |||
| parser.pathname = parser.pathname + '/recent-updates'; | |||
| $.ajax({ | |||
| url: parser.href, | |||
| // Don't show plone default spinner | |||
| global: false, | |||
There was a problem hiding this comment.
http://api.jquery.com/jquery.ajax/
global (default: true)
Type: Boolean
Whether to trigger global Ajax event handlers for this request. The default is true. Set to
false to prevent the global handlers like ajaxStart or ajaxStop from being triggered. This
can be used to control various Ajax Events.
There was a problem hiding this comment.
rodfersou
commented
Mar 3, 2017
| @@ -95,6 +95,8 @@ | |||
| parser.pathname = parser.pathname + '/recent-updates'; | |||
| $.ajax({ | |||
| url: parser.href, | |||
| // Don't show plone default spinner | |||
| global: false, | |||
There was a problem hiding this comment.
http://api.jquery.com/jquery.ajax/
global (default: true)
Type: Boolean
Whether to trigger global Ajax event handlers for this request. The default is true. Set to
false to prevent the global handlers like ajaxStart or ajaxStop from being triggered. This
can be used to control various Ajax Events.
There was a problem hiding this comment.
|
I don't see any problems if the spinner is only duplicated during AJAX calls; I thinks it's even better to show it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #35