Set caches directory on Fuchsia (flutter#18321)

colorhook · May 20, 2020 · cdc5ed3 · cdc5ed3
1 parent 0d27687
commit cdc5ed3
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/fml/platform/fuchsia/paths_fuchsia.cc b/fml/platform/fuchsia/paths_fuchsia.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "flutter/fml/file.h"
 #include "flutter/fml/paths.h"
 
 namespace fml {
@@ -12,8 +13,7 @@ std::pair<bool, std::string> GetExecutableDirectoryPath() {
 }
 
 fml::UniqueFD GetCachesDirectory() {
-  // Unsupported on this platform.
-  return {};
+  return OpenDirectory("/cache", false, fml::FilePermission::kRead);
 }
 
 }  // namespace paths

diff --git a/shell/platform/fuchsia/flutter/meta/flutter_aot_product_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_aot_product_runner.cmx
@@ -6,7 +6,8 @@
     "features": [
       "config-data",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",

diff --git a/shell/platform/fuchsia/flutter/meta/flutter_aot_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_aot_runner.cmx
@@ -6,7 +6,8 @@
     "features": [
       "config-data",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",

diff --git a/shell/platform/fuchsia/flutter/meta/flutter_jit_product_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_jit_product_runner.cmx
@@ -7,7 +7,8 @@
       "config-data",
       "deprecated-ambient-replace-as-executable",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",

diff --git a/shell/platform/fuchsia/flutter/meta/flutter_jit_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_jit_runner.cmx
@@ -7,7 +7,8 @@
       "config-data",
       "deprecated-ambient-replace-as-executable",
       "root-ssl-certificates",
-      "vulkan"
+      "vulkan",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.SettingsManager",

diff --git a/testing/fuchsia/meta/fuchsia_test.cmx b/testing/fuchsia/meta/fuchsia_test.cmx
@@ -5,7 +5,8 @@
   "sandbox": {
     "features": [
       "vulkan",
-      "deprecated-ambient-replace-as-executable"
+      "deprecated-ambient-replace-as-executable",
+      "isolated-cache-storage"
     ],
     "services": [
       "fuchsia.accessibility.semantics.SemanticsManager",