Skip to content

refactor(git): extract _create_commit_cmd_string, better test coverage #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented May 19, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (856ca4f) to head (575ad78).
Report is 3 commits behind head on refactors.

Additional details and impacted files
@@            Coverage Diff             @@
##           refactors    #1442   +/-   ##
==========================================
  Coverage      97.78%   97.79%           
==========================================
  Files             57       57           
  Lines           2620     2625    +5     
==========================================
+ Hits            2562     2567    +5     
  Misses            58       58           
Flag Coverage Δ
unittests 97.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism
Copy link
Contributor Author

I think I encountered the same issue:

#740 (comment)

@Lee-W Lee-W changed the base branch from master to refactors May 22, 2025 03:46
@bearomorphism bearomorphism force-pushed the refactor-git-2 branch 3 times, most recently from 5dddd48 to 0842d37 Compare May 23, 2025 08:28
@bearomorphism bearomorphism requested a review from Lee-W May 23, 2025 08:30
@bearomorphism bearomorphism changed the title refactor(git): extract _get_commit_command refactor(git): extract _create_commit_cmd_string, better test coverage May 23, 2025
@bearomorphism bearomorphism mentioned this pull request May 25, 2025
10 tasks
@Lee-W Lee-W merged commit 9584c49 into commitizen-tools:refactors May 26, 2025
18 checks passed
@bearomorphism bearomorphism deleted the refactor-git-2 branch June 1, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants