-
-
Notifications
You must be signed in to change notification settings - Fork 286
refactor(git): extract _create_commit_cmd_string, better test coverage #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 2 commits into
commitizen-tools:refactors
from
bearomorphism:refactor-git-2
May 26, 2025
Merged
refactor(git): extract _create_commit_cmd_string, better test coverage #1442
Lee-W
merged 2 commits into
commitizen-tools:refactors
from
bearomorphism:refactor-git-2
May 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1442 +/- ##
==========================================
Coverage 97.78% 97.79%
==========================================
Files 57 57
Lines 2620 2625 +5
==========================================
+ Hits 2562 2567 +5
Misses 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fe16989
to
2bde082
Compare
I think I encountered the same issue: |
Lee-W
reviewed
May 22, 2025
5dddd48
to
0842d37
Compare
Lee-W
approved these changes
May 25, 2025
0842d37
to
575ad78
Compare
Lee-W
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context