-
-
Notifications
You must be signed in to change notification settings - Fork 286
ci(pyproject.toml): strict check for invalid commit messages #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci(pyproject.toml): strict check for invalid commit messages #1494
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
+ Coverage 97.33% 97.62% +0.28%
==========================================
Files 42 57 +15
Lines 2104 2653 +549
==========================================
+ Hits 2048 2590 +542
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a46c33d
to
1dffc7d
Compare
1dffc7d
to
74d92d2
Compare
check-commit.help = "Check the commit message" | ||
check-commit.cmd = "cz -nr 3 check --rev-range origin/master.." | ||
check-commit.help = "Check the commit messages" | ||
check-commit.cmd = "poetry run cz --no-raise 3 check --rev-range origin/master.." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added poetry run
so the command can run on windows platform.
btw it would be great if we can check in this PR after #1457 because there will probably be conflicts and I want to fix the conflicts in this branch. |
let's mark it draft then |
Closes #1493
Description
check-commit
task beforecover
inpoetry all
command.Checklist
Expected Behavior
Steps to Test This Pull Request
#1495 CI should not pass.
Additional Context