Skip to content

ci(pyproject.toml): strict check for invalid commit messages #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Jun 2, 2025

Closes #1493

Description

  • Check whether the commit messages of a PR follows Conventional Commits pattern in CI.
  • Move check-commit task before cover in poetry all command.

Checklist

Expected Behavior

Steps to Test This Pull Request

#1495 CI should not pass.

Additional Context

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (120d514) to head (e192688).
Report is 657 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1494      +/-   ##
==========================================
+ Coverage   97.33%   97.62%   +0.28%     
==========================================
  Files          42       57      +15     
  Lines        2104     2653     +549     
==========================================
+ Hits         2048     2590     +542     
- Misses         56       63       +7     
Flag Coverage Δ
unittests 97.62% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism marked this pull request as draft June 2, 2025 05:43
@bearomorphism bearomorphism force-pushed the ci-pr-check-fix branch 3 times, most recently from a46c33d to 1dffc7d Compare June 2, 2025 05:59
@bearomorphism bearomorphism marked this pull request as ready for review June 2, 2025 06:27
check-commit.help = "Check the commit message"
check-commit.cmd = "cz -nr 3 check --rev-range origin/master.."
check-commit.help = "Check the commit messages"
check-commit.cmd = "poetry run cz --no-raise 3 check --rev-range origin/master.."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added poetry run so the command can run on windows platform.

@bearomorphism
Copy link
Contributor Author

btw it would be great if we can check in this PR after #1457 because there will probably be conflicts and I want to fix the conflicts in this branch.

@Lee-W Lee-W marked this pull request as draft June 4, 2025 14:47
@Lee-W
Copy link
Member

Lee-W commented Jun 4, 2025

btw it would be great if we can check in this PR after #1457 because there will probably be conflicts and I want to fix the conflicts in this branch.

let's mark it draft then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check every commit message in PR CI
2 participants