Skip to content

Conversation

danchev
Copy link
Contributor

@danchev danchev commented Aug 27, 2025

Issue: tmbo/questionary#454

Description

Exclude transient dependency that breaks commitizen

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO    -  Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

uv run --with . git-cz c --dry-run

Additional Context

@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 19:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a version exclusion for the prompt_toolkit package to resolve a compatibility issue with the questionary library. The change prevents the installation of prompt_toolkit version 3.0.52, which has a known issue that breaks commitizen functionality.

  • Excludes prompt_toolkit version 3.0.52 as a transitive dependency constraint

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.96%. Comparing base (120d514) to head (6c7f454).
⚠️ Report is 758 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
+ Coverage   97.33%   97.96%   +0.62%     
==========================================
  Files          42       58      +16     
  Lines        2104     2703     +599     
==========================================
+ Hits         2048     2648     +600     
+ Misses         56       55       -1     
Flag Coverage Δ
unittests 97.96% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W changed the base branch from master to v4-9-0-test August 28, 2025 02:18
@Lee-W Lee-W changed the base branch from v4-9-0-test to master August 28, 2025 02:27
@Lee-W Lee-W merged commit 75a97e5 into commitizen-tools:master Aug 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants