feat: add rootnet weight delegation (#188)

* feat: add rootnet weight delegation

* fix: benchmarks

* chore: update codeowners

* chore: updated CODEOWNERS

* feat: adding funding.yml

* refac: fofo

* chore: fix docstings

* wip: removal subnet migration

* refac: fixing migration, removing

* test: add weight_control_delegation unit test

* refac: migration

---------

Co-authored-by: YourUsername <[email protected]>

.github/CODEOWNERS

@@ -1,7 +1,3 @@
-validator_hyperparameters.md @unconst
-validator_hyperparameters.md @shibshib
-validator_hyperparameters.md @opentaco
+/.github/workflows @DaviPtrs
 
-.github/CODEOWNERS @unconst
-.github/CODEOWNERS @shibshib
-.github/CODEOWNERS @opentaco
+* @Supremesource @devwckd @aripiprazole @saiintbrisson

.github/FUNDING.yml

@@ -0,0 +1 @@
+custom: ["https://governance.communeai.org/"]

.github/pull_request_template.md

@@ -0,0 +1,17 @@
+# Pull Request Checklist
+
+Before submitting this PR, please make sure:
+
+- [ ] You have run `cargo clippy` and addressed any warnings
+- [ ] You have added appropriate tests (if applicable)
+- [ ] You have updated the documentation (if applicable)
+- [ ] You have reviewed your own code
+- [ ] You have updated changelog (if applicable)
+
+## Description
+
+Please provide a brief description of the changes in this PR.
+
+## Related Issues
+
+Please link any related issues here

CHANGELOG.md

@@ -19,6 +19,7 @@ diff [here](https://github.com/agicommies/subspace-network/compare/db8a19b1d2155
   - `MinStake` storage map / subnet parameter was removed
   - `SubnetImmunityPeriod`storage value / global parameter was introduced
   - `SubnetRegistrationBlock` storage map was introduced
+  - `TotalSubnets` storage value was removed
   - `MinimumAllowedStake` was introduced. Users cannot stake or unstake a value smaller than this minimum.
   - `MinImmunityStake` was introduced. This value is a subnet parameter that can be changed by the subnet owner. A validator (key) with delegated stake higher than or equal to this value is immune to deregistrations. This aims to reduce sudden validator deregistrations, with adaptability to subnet owner's consensus.
 - Extrinsics changes:

pallets/governance/src/benchmarking.rs

@@ -27,29 +27,28 @@ fn submit_dao_application<T: Config>() -> Result<(), &'static str> {
 fn register_mock<T: Config>(
     key: T::AccountId,
     module_key: T::AccountId,
-    stake: u64,
     name: Vec<u8>,
 ) -> Result<(), &'static str> {
     let address = "test".as_bytes().to_vec();
     let network = "testnet".as_bytes().to_vec();
-    BurnConfig::<T>::mutate(|cfg| cfg.min_burn = 0);
+
+    let enough_stake = 10000000000000u64;
     SubspaceMod::<T>::add_balance_to_account(
         &key,
-        SubspaceMod::<T>::u64_to_balance(stake + SubnetBurn::<T>::get() + 2000).unwrap(),
+        SubspaceMod::<T>::u64_to_balance(SubnetBurn::<T>::get() + enough_stake).unwrap(),
     );
     let metadata = Some("metadata".as_bytes().to_vec());
     SubspaceMod::<T>::register(
-        RawOrigin::Signed(key).into(),
+        RawOrigin::Signed(key.clone()).into(),
         network,
         name,
         address,
-        stake.into(),
-        module_key,
+        module_key.clone(),
         metadata,
     )?;
+    SubspaceMod::<T>::increase_stake(&key, &module_key, enough_stake);
     Ok(())
 }
-
 benchmarks! {
     //---------------------------------
     //Adding proposals
@@ -88,7 +87,8 @@ benchmarks! {
             params.governance_config.proposal_expiration,                // proposal_expiration: the block number, proposal expires at
             params.general_subnet_application_cost,     // general_subnet_application_cost
             params.kappa,
-            params.rho
+            params.rho,
+            params.subnet_immunity_period
         )
 
 
@@ -97,7 +97,7 @@ benchmarks! {
         let caller: T::AccountId = account("Alice", 0, 1);
 
         // register the subnet
-        register_mock::<T>(caller.clone(), caller.clone(), 100000000000000u64 + SubnetBurn::<T>::get(),
+        register_mock::<T>(caller.clone(), caller.clone(),
     "test".as_bytes().to_vec())?;
         let netuid = SubspaceMod::<T>::get_netuid_for_name("testnet".as_bytes()).unwrap();
 
@@ -173,7 +173,7 @@ benchmarks! {
     add_subnet_custom_proposal {
         let caller: T::AccountId = account("Alice", 0, 1);
         // The subnet has to exist
-        register_mock::<T>(caller.clone(), caller.clone(), 100000000000000u64,
+        register_mock::<T>(caller.clone(), caller.clone(),
     "test".as_bytes().to_vec())?;     // Add alice fund to submit the proposal
         SubspaceMod::<T>::add_balance_to_account(&caller,
     SubspaceMod::<T>::u64_to_balance(1_000_000_000_000_000).unwrap());
@@ -204,7 +204,7 @@ benchmarks! {
     vote_proposal {
         let caller: T::AccountId = account("Alice", 0, 1);
         // Register Alice such that she has funds to vote
-        register_mock::<T>(caller.clone(), caller.clone(), 100000000000000u64, "test".as_bytes().to_vec())?;
+        register_mock::<T>(caller.clone(), caller.clone(), "test".as_bytes().to_vec())?;
 
         // Add Alice's funds to submit the proposal
         SubspaceMod::<T>::add_balance_to_account(&caller, SubspaceMod::<T>::u64_to_balance(1_000_000_000_000_000).unwrap());
@@ -221,7 +221,7 @@ benchmarks! {
     remove_vote_proposal {
         let caller: T::AccountId = account("Alice", 0, 1);
         // Register Alice such that she has funds to vote
-        register_mock::<T>(caller.clone(), caller.clone(), 100000000000000u64, "test".as_bytes().to_vec())?;
+        register_mock::<T>(caller.clone(), caller.clone(), "test".as_bytes().to_vec())?;
 
         // Add Alice's funds to submit the proposal
         SubspaceMod::<T>::add_balance_to_account(&caller, SubspaceMod::<T>::u64_to_balance(1_000_000_000_000_000).unwrap());

pallets/governance/src/lib.rs

@@ -378,22 +378,25 @@ pub mod pallet {
     #[pallet::event]
     #[pallet::generate_deposit(pub(crate) fn deposit_event)]
     pub enum Event<T: Config> {
+        /// A new proposal has been created.
         ProposalCreated(ProposalId),
-
+        /// A proposal has been accepted.
         ProposalAccepted(ProposalId),
+        /// A proposal has been refused.
         ProposalRefused(ProposalId),
+        /// A proposal has expired.
         ProposalExpired(ProposalId),
-
+        /// A vote has been cast on a proposal.
         ProposalVoted(u64, T::AccountId, bool),
+        /// A vote has been unregistered from a proposal.
         ProposalVoteUnregistered(u64, T::AccountId),
-
-        WhitelistModuleAdded(T::AccountId), /* --- Event created when a module account has been
-                                             * added to the whitelist. */
-        WhitelistModuleRemoved(T::AccountId), /* --- Event created when a module account has
-                                               * been removed from the whitelist. */
+        /// A module account has been added to the whitelist.
+        WhitelistModuleAdded(T::AccountId),
+        /// A module account has been removed from the whitelist.
+        WhitelistModuleRemoved(T::AccountId),
+        /// A new application has been created.
         ApplicationCreated(u64),
     }
-
     // ---------------------------------
     // Errors
     // ---------------------------------
@@ -443,21 +446,27 @@ pub mod pallet {
         VoteModeIsNotAuthority,
         /// An internal error occurred, probably relating to the size of the bounded sets.
         InternalError,
-
-        // DAO / Governance
+        /// The application data is too small or empty.
         ApplicationTooSmall,
+        /// The application data is too large, exceeding the maximum allowed size.
         ApplicationTooLarge,
+        /// The application is not in a pending state.
         ApplicationNotPending,
+        /// The application data is invalid or malformed.
         InvalidApplication,
+        /// The account doesn't have enough balance to submit an application.
         NotEnoughtBalnceToApply,
+        /// The recommended weight for the application is invalid.
         InvalidRecommendedWeight,
-        NotCurator, /* --- Thrown when the user tries to set the curator and is not the
-                     * curator */
+        /// The operation can only be performed by the curator.
+        NotCurator,
+        /// The application with the given ID was not found.
         ApplicationNotFound,
-        AlreadyWhitelisted, /* --- Thrown when the user tries to whitelist an account that is
-                             * already whitelisted. */
-        NotWhitelisted, /* --- Thrown when the user tries to remove an account from the
-                         * whitelist that is not whitelisted. */
+        /// The account is already whitelisted and cannot be added again.
+        AlreadyWhitelisted,
+        /// The account is not whitelisted and cannot be removed from the whitelist.
+        NotWhitelisted,
+        /// Failed to convert the given value to a balance.
         CouldNotConvertToBalance,
     }
 }