Fix scaled in Box
#1399
Merged
Fix scaled in Box
#1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
+ Coverage 60.27% 60.68% +0.41%
==========================================
Files 207 207
Lines 22258 22262 +4
==========================================
+ Hits 13415 13510 +95
+ Misses 8843 8752 -91 ☔ View full report in Codecov by Sentry. |
chenkasirer
reviewed
Oct 15, 2024
| @@ -575,6 +575,28 @@ def scale(self, factor): | |||
| self.ysize *= factor | |||
| self.zsize *= factor | |||
|
|
|||
| def scaled(self, x, y=None, z=None): | |||
There was a problem hiding this comment.
why not make scale the same and then use it here?
There was a problem hiding this comment.
yes, of course, you're totally right, changed it here: 7959604
this is now a breaking change because the argument names have changed, even if positionally it would be a non-breaking change
chenkasirer
reviewed
Oct 15, 2024
chenkasirer
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny bug fix
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.