Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3 #4

Merged
merged 2 commits into from
Nov 24, 2014
Merged

Issue 3 #4

merged 2 commits into from
Nov 24, 2014

Conversation

zouzias
Copy link

@zouzias zouzias commented Nov 21, 2014

Fixes #3

I had to add an ubuntu.sh puppet-bootstrap script in Vagrantfile. It ensures that puppet is installed with the latest version.

Also installed ElasticSearch HQ plugin (useful for checking the es indices):
http://localhost:9200/_plugin/HQ/

@Murhaf
Copy link
Contributor

Murhaf commented Nov 24, 2014

thanks for doing this! I tested it on a Windows machine and it worked 👍

I'm getting some deprecation warnings though:
==> default: Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations
==> default: (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning')

I think this has something to do with the fact that we are using the latest puppet while the modules are a bit older, see: https://docs.puppetlabs.com/puppet/latest/reference/environments_classic.html#config-file-environments-are-deprecated

I think it should okay to merge even though there are a couple of warnings, do you agree?

@zouzias
Copy link
Author

zouzias commented Nov 24, 2014

I am also getting these deprecation warnings, but I do not think that they might cause any issue. Feel free to merge.

Murhaf added a commit that referenced this pull request Nov 24, 2014
@Murhaf Murhaf merged commit ce6949b into comperiosearch:master Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch parameters do not initialize properly.
2 participants