Skip to content

GHA: setup swift toolchain version information #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

compnerd
Copy link
Owner

This embeds a compiler version tag into the output so that we can easily identify the toolchain.

This embeds a compiler version tag into the output so that we can easily
identify the toolchain.
@compnerd compnerd requested review from Steelskin and Copilot June 20, 2025 17:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR embeds the Swift toolchain version and tag into the build output to improve traceability.

  • Adds a new SWIFT_TOOLCHAIN_VERSION compile-time definition combining swift_version and swift_tag
  • Ensures the CI workflow captures both version and tag metadata
  • Updates the GitHub Actions workflow file to include the new input in the build definitions
Comments suppressed due to low confidence (2)

.github/workflows/swift-toolchain.yml:1178

  • [nitpick] Using a space to concatenate swift_version and swift_tag can make downstream parsing brittle. Consider joining them with a consistent delimiter (e.g., -) or templating them in a single string in the workflow inputs to avoid ambiguous splits.
                -D SWIFT_TOOLCHAIN_VERSION="${{ inputs.swift_version}} ${{ inputs.swift_tag }}" `

.github/workflows/swift-toolchain.yml:1178

  • Verify that the swift_tag input is declared in the workflow_dispatch inputs. If it isn't defined, this reference will be unresolved and cause the build to fail.
                -D SWIFT_TOOLCHAIN_VERSION="${{ inputs.swift_version}} ${{ inputs.swift_tag }}" `

@compnerd compnerd merged commit 6ccebfe into main Jun 23, 2025
1 check passed
@compnerd compnerd deleted the compnerd/tag branch June 23, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants