GHA: add swift-subprocess revision tracking #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Steelskin
reviewed
Jul 16, 2025
compnerd
force-pushed
the
compnerd/subprocess
branch
from
5056c3c to
84a722f
Compare
Prepare for building swift-subprocess, start tracking the revision information.
compnerd
force-pushed
the
compnerd/subprocess
branch
from
84a722f to
6a8f835
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds swift-subprocess revision tracking to the GitHub Actions workflows in preparation for building the swift-subprocess component. The change introduces a new input parameter to track the revision information for swift-subprocess across the build pipeline.
- Adds
swift_subprocess_revisionas a required input parameter to the swift-toolchain workflow - Propagates the swift-subprocess revision through the build-toolchain workflow by adding it to job outputs and inputs
- Sets the default revision to
refs/heads/mainin the context setup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/swift-toolchain.yml |
Adds swift_subprocess_revision as a required string input parameter |
.github/workflows/build-toolchain.yml |
Propagates swift_subprocess_revision through job outputs and inputs, sets default to main branch |
Steelskin
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for building swift-subprocess, start tracking the revision information.