-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn install caching #386
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 3d93916.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem like this is speeding up anything? If it does though, let's merge!
It should, most steps even inside this job use cached dependencies like here https://github.com/compound-finance/comet/runs/6942130256?check_suite_focus=true Also, it should be useful for the deployment step when the same job can be run multiple times due to rate limiting. |
But just empirically, compare to e.g. https://github.com/compound-finance/comet/actions/runs/2551760112 it took 6m with the caching and 5m without? |
An attempt to speed up build and migrations