Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn install caching #386

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

toninorair
Copy link
Contributor

An attempt to speed up build and migrations

@toninorair toninorair marked this pull request as draft June 13, 2022 23:52
@toninorair toninorair marked this pull request as ready for review June 17, 2022 20:40
Copy link
Contributor

@jflatow jflatow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like this is speeding up anything? If it does though, let's merge!

@toninorair toninorair changed the title add yarn install caching Add yarn install caching Jun 23, 2022
@toninorair
Copy link
Contributor Author

Doesn't seem like this is speeding up anything? If it does though, let's merge!

It should, most steps even inside this job use cached dependencies like here https://github.com/compound-finance/comet/runs/6942130256?check_suite_focus=true

Also, it should be useful for the deployment step when the same job can be run multiple times due to rate limiting.

@jflatow
Copy link
Contributor

jflatow commented Jun 23, 2022

Doesn't seem like this is speeding up anything? If it does though, let's merge!

It should, most steps even inside this job use cached dependencies like here https://github.com/compound-finance/comet/runs/6942130256?check_suite_focus=true

Also, it should be useful for the deployment step when the same job can be run multiple times due to rate limiting.

But just empirically, compare to e.g. https://github.com/compound-finance/comet/actions/runs/2551760112 it took 6m with the caching and 5m without?

@jflatow jflatow added potential enhancement Potential features revisit This PR is worth keeping open but approach needs to be revisited labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential enhancement Potential features revisit This PR is worth keeping open but approach needs to be revisited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants